834
0%

Ran 08 Oct 2016 02:25PM UTC

Jobs 5

Files 422

Run time 2min

Badge

Embed ▾

pending completion

Build # 834

Build Type

push

travis-ci

Committed by

fujita

Commit Message

ryu/lib/ofctl_v1_3: port name decoding fix

The patch resolves issue experienced when decoding certain values of
name field in OFPMP_PORT_DESCRIPTION body. Non-decodable bytes are
replaced with utf-8 replacement character.

This issue was observed while retrieving OFPMP_PORT_DESC reply from
OpenFlow 1.3 compliant HP switch. One of ofp_struct structures
describing OFPP_LOCAL port has a name field with value 4f 46 50 50 5f 4c
4f 43 41 4c 00 81 ff ff ff ff that translates to OFPP_LOCAL.......
Attempt to decode the value, as in modified line, raises an exception
"UnicodeDecodeError: 'utf8' codec can't decode byte 0x81 in position 11:
invalid start byte". In the submitted patch, non-decodable characters
are replaced with utf-8 REPLACEMENT CHARACTER (U+FFFD), which is
sufficient for the get_port_desc method to work seamlessly. Similar
usages of str.decode method may be found in ofctl_v1_3, ofctl_v1_4,
ofctl_v1_5 and need to be fixed in the future.

Signed-off-by: Michal Rzepka <mrzepka@student.agh.edu.pl>
Reviewed-by: Iwase Yusuke <iwase.yusuke0@gmail.com>
Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>

Run Details

50025 of 76805 relevant lines covered (65.13%)

2.6 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	834.1 (TOX_ENV=py27)	08 Oct 2016 02:26PM UTC	65.1	Travis Job 834.1
2	834.2 (TOX_ENV=py34)	08 Oct 2016 02:26PM UTC	65.1	Travis Job 834.2
3	834.3 (TOX_ENV=py35)	08 Oct 2016 02:27PM UTC	65.1	Travis Job 834.3
4	834.4 (TOX_ENV=pypy26)	08 Oct 2016 02:27PM UTC	65.1	Travis Job 834.4
5	834.5 (TOX_ENV=pep8)	08 Oct 2016 02:25PM UTC		Travis Job 834.5

Source Files on build 834

Detailed source file information is not available for this build.

osrg / ryu / 834
0%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 834

osrg / ryu / 834 0%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 834

osrg / ryu / 834
0%

README BADGES
x