solidjs / solid / 39335187509

79%

main: 89%

push

github

fix(signals): an unread key written beside a held sibling publishes at flush (#4146) (#4159)

* fix(signals): unread key written beside a held sibling publishes at flush (#4146)

A setter outside the holding transaction writing a store key that a held
container's staging left unchanged wrote it into the held staging, so plain
reads waited for the hold's landing, unless a live reader's leaf gave the
key its own staging. The key now gets its leaf before the write (R1, #3706),
kept while the container is held.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015hPxMkC3jg3Uivh65gvaf2

* fix(signals): golf the #4146 held-key leaf (+80 B min on store scenarios)

Inline the leaf creation into the set trap and fold the held-host check
into the existing release conditions; drop conditions the remaining ones
already cover.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015hPxMkC3jg3Uivh65gvaf2

* size: raise store caps for the #4146 held-key leaf

CI measured +80 B minified on the two store scenarios. Caps at CI
brotli + 10 B, recorded minified = CI's minified.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015hPxMkC3jg3Uivh65gvaf2

* docs(signals): regenerate RULES-INDEX for the golfed #4146 leaf

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015hPxMkC3jg3Uivh65gvaf2

* fix(signals): share slotKept, give every held-container write its leaf (#4146)

Golf from review of #4159 (-32 B min on the store scenarios):

- G1: one `slotKept(node)` predicate for the slot-release handler and the
  deferred-release drain (no behaviour change).
- G2: drop `key in pb` and `!heldKeyChanged` from the set trap. `bornStaged`
  already holds a leaf only for a key the held staging changed, so a changed
  key ... (continued)

756 of 1050 branches covered (72.0%)

Branch coverage included in aggregate %.

1103 of 1347 relevant lines covered (81.89%)

27.56 hits per line