astronomer / astro-cli / 39316606692

61%

main: 45%

Build Type

push

github

Committed by web-flow

Commit Message

Deploy APC's --image-name and --remote through the shared manifest route (#2365)

* Deploy APC's --image-name and --remote through the shared manifest route

Under an Astro Private Cloud context, `astro deploy --image-name` (local, or
with --remote already in a registry) took APC's 1.x route: the Deployment was
a raw Houston id or the old picker, the runtime was a --yes confirmation, and
nothing resolved the project's apc links. Both now run through
internal/deploy's Run, as Astro's --image-name does and as a project's build
on APC already did:

- the Deployment resolves from apc links, ids, the default link preselected,
  input_required when it cannot ask, and a link on another domain is refused
  with the way there; -o json carries `link`;
- a local image skips the build in DeployManifestImage: its runtime is its
  label (deploybuild.PrebuiltRuntime), held to CheckBuiltListed's rules, and it
  is pushed by pushManifestImage (the Deployment's registry, registry.<domain>
  below 1.0, BYO by the mutation, where it keeps its own tag as 1.x did);
- --remote keeps its no-pull, no-push updateDeploymentImage
  (registry_image.go), now with --runtime-version held to the same runtime
  rules and the deploy's description sent; a platform that has not turned the
  mutation on is told the setting an admin turns it on with;
- the DAGs follow either as a build's do from a project, and outside a project
  the image ships alone with the same notices as before.

--yes is removed: it answered only the old route's runtime and empty-dags
questions, which are now refusals or warnings, and it was never a 1.x flag of
this command, so it takes no tombstone. --prompt becomes the hidden no-op it
is on Astro: the deploy asks whenever no Deployment is named.
--runtime-version without --remote is still taken, with a warning that it
does nothing. The old route (deploy.Airflow, UpdateDeploymentImage, the push,
the picker and the confirmations) is deleted; its tests are rewritten o... (continued)

Coverage Stats

300 of 312 new or added lines in 7 files covered. (96.15%)

3 existing lines in 1 file now uncovered.

40962 of 67918 relevant lines covered (60.31%)

303.92 hits per line