ponder-lab / Hybridize-Functions-Refactoring / #3629
90%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 48
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 88.653%. Remained the same
#3629

push

github

web-flow 
Pin dictionary fill-ins against a missing `dict.copy` model (#1128)

* Pin dictionary fill-ins against a missing `dict.copy` model

Add three cases beside `make_features_of_copy` in `testReboundStateReads`, following OpenNMT-tf's
`SequenceRecordInputter.make_features` and its callers: a copy that always holds "tensor", so the
body returns before writing (`make_features_of_full_copy`); an empty dictionary per inputter, as
`ParallelInputter` passes (`RecordInputter.make_features`); and no dictionary at all
(`make_features_fresh`). Each pins today's decision, with a TODO linking wala/ML#1082 where a
`dict.copy` model is expected to move it. Correct the comment that said `make_features_of_copy`
is called as OpenNMT-tf's `Model` calls it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NTnpjPjJj2aZy1ZkUD1eAn

* Say what the dictionary pins do and don't cover

State the full-copy case's TODO as an expectation: it links the change expected to move it, not a
fix. Say that the per-inputter case has OpenNMT-tf's `ParallelInputter` shape but doesn't reproduce
what keeps OpenNMT-tf's own `SequenceRecordInputter.make_features` converted.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NTnpjPjJj2aZy1ZkUD1eAn

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

5297 of 5975 relevant lines covered (88.65%)

0.89 hits per line

Jobs
ID Job ID Ran Files Coverage
1 #3629.1 48
88.65
Source Files on build #3629