supabase / supabase-swift / 39292096514

94%

Build Type

push

github

Committed by web-flow

Commit Message

feat(helpers): add immediate tasks, TaskStorage, and a non-Sendable withTimeout (#1590)

* feat(helpers): add immediate tasks, TaskStorage, and a non-Sendable withTimeout

Adds the concurrency tools the Realtime v3 isolation work builds on:

- `Task.immediateIfAvailable`: runs the body inline up to its first suspension
  on OS 26 (`Task.immediate`), falls back to a plain `Task` elsewhere, and
  inherits the caller's actor either way.
- `TaskStorage<Location>`: owns unstructured tasks by the reason they exist;
  `replace(_:at:)` cancels the previous run at that location, `cancelAll()`
  and `deinit` cancel everything.
- `withTimeout(_:clock:body:)` now takes a non-`Sendable`, non-escaping body
  and no longer requires `@Sendable @concurrent`, so callers can capture
  actor-isolated state. The `clock:` parameter stays for tests.

* fix(helpers): run the withTimeout body on the caller's actor

`withTimeout` ran `body` in a task-group child, so an actor method that
captured its own state in the body touched that state from the global
executor. The debug runtime reported it ("actor-isolated function was not
called on the same actor") and on arm64 the write could stay invisible to
the actor: `RealtimeChannel.runUnsubscribe` set `closeWaiter` off-actor,
`didReceiveClose` never saw it, and the unsubscribe hung. Three channel
subscription tests failed on CI from this.

The child task now hops to the caller's isolation (`#isolation`) before
calling the body. A new test runs the body from an actor with a recording
executor and checks that it ran as one of that actor's jobs; it fails on
the old implementation.

* test(helpers): implement asUnownedSerialExecutor for the iOS 16 floor

The stdlib default needs iOS 17 / macOS 14, so every iOS xcodebuild job failed
to compile RecordingExecutor.

Also remove the TestClock race from the two deadline tests: a Task that sleeps
on the clock could register its sleep after advance() ran, which hung the Linux
run until the jo... (continued)

Coverage Stats

68 of 73 new or added lines in 3 files covered. (93.15%)

3 existing lines in 1 file now uncovered.

13348 of 14580 relevant lines covered (91.55%)

1871.92 hits per line