fourTheorem / slic-watch / 39265872078

97%

push

github

fix(s3): derive FilterId from bucket metrics configurations and add request metrics (#131)

* fix(s3): derive FilterId from bucket metrics configurations

S3 alarms and dashboard widgets used a hardcoded FilterId of
EntireBucket, so they showed no data when a bucket's metrics
configuration used any other Id.

- Alarms use the Id of the metrics configuration covering the entire
  bucket (no Prefix, TagFilters or AccessPointArn)
- Dashboard widgets show a line for every metrics configuration,
  labelled with the bucket name and FilterId
- Buckets without MetricsConfigurations keep using EntireBucket, the
  S3 console default
- Dashboard widget config comes from the service-level S3 config, so a
  resource-level override no longer applies to every bucket

Closes #129

* feat(s3): add request type and data transfer metrics

Add dashboard widgets for GetRequests, PutRequests, DeleteRequests,
PostRequests, ListRequests, BytesDownloaded and BytesUploaded.

Alarms for these metrics are disabled by default, as normal traffic
levels vary by workload. Enabling an S3 alarm without a Threshold now
fails with an error instead of producing an invalid alarm.

Closes #130

* fix(core): type child nodes in cascade

Resolves the TypeScript error where child config nodes were inferred
as unknown when passed to cascade.

* docs(s3): update dashboard screenshots and request metric alarm notes

Replace the S3 widget screenshots with ones showing per-FilterId lines,
split latency widgets into Average and P99 images, and add screenshots
for the request type and data transfer widgets. Clarify that request
type alarms need a Threshold when enabled.

* fix(s3): resolve intrinsic FilterIds and always validate alarm thresholds

Resolve metrics configuration Ids given as Ref, Fn::GetAtt or Fn::Sub,
treat an empty Prefix or TagFilters as covering the entire bucket, and
fall back to EntireBucket when MetricsConfigurations cannot be resolved
before deployment, as before FilterIds were... (continued)

271 of 315 branches covered (86.03%)

Branch coverage included in aggregate %.

181 of 203 new or added lines in 5 files covered. (89.16%)

3484 of 3557 relevant lines covered (97.95%)

113.11 hits per line