openconfig / ygot / 39255724724

88%

master: 89%

Build Type

Pull #1111

github

Committed by alshabib

Commit Message

ytypes: optimize single-key list lookup in retrieveNodeList to O(1)

Currently, retrieveNodeList iterates over all map keys via rv.MapKeys()
and invokes getKeyValue (which reflects over every struct field and
parses YANG path struct tags) for every existing list element on each
ytypes.SetNode / retrieveNode call. Inserting N elements into a YANG
list therefore performs O(N^2) struct-tag parses and reflection lookups.

For single-keyed lists (where the map key is not a struct) and
non-wildcard/non-partial-key queries:
1. Convert the gNMI path key string to the map key's reflect.Type via
   StringToType and perform a direct O(1) rv.MapIndex(kfv) lookup.
2. When the element is absent and modifyRoot is set, insert the new
   entry directly via insertAndGetKey without scanning existing keys.
3. For types where StringToType cannot directly construct the map key
   (e.g., union interface keys), pre-compute the key field struct index
   once outside the rv.MapKeys() loop instead of calling getKeyValue on
   every element.

Pull Request Pull Request #1111: ytypes: optimize single-key list lookup in retrieveNodeList to O(1)

Coverage Stats

31 of 64 new or added lines in 1 file covered. (48.44%)

23 existing lines in 2 files now uncovered.

14036 of 15870 relevant lines covered (88.44%)

483.92 hits per line