opendefensecloud / solution-arsenal / 39226934676
79%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 97
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 79.115%. Remained the same
39226934676

push

github

web-flow 
chore(ui): run eslint on the TypeScript 6 API again (#865)

## What

`pnpm lint` (`make ui-lint`) works again.

- `typescript` -> alias for `@typescript/typescript6@~6.0.2`, this is
what typescript-eslint imports
- `@typescript/native` -> alias for `typescript@~7.0.0`, keeps the 7.0
`tsc` binary for the build

## Why

Since the bump to TypeScript 7 (#691) the linter crashes before it lints
a single file:

```console
$ pnpm lint
typescript-eslint does not support TS 7.0.
Error: typescript-eslint does not support TS 7.0.
```

`typescript-eslint/dist/index.js` throws on `versionMajor >= 7`. TS 7.0
ships without a programmatic API, and the newest typescript-eslint
(8.71.2) still declares `typescript: >=4.8.4 <6.1.0`, so bumping the
linter does not help.

The side-by-side install is the setup the [TypeScript 7.0 release
notes](https://devblogs.microsoft.com/typescript/announcing-typescript-7-0/#running-side-by-side-with-typescript-6.0)
describe for exactly this case. We keep compiling with 7, only the tools
that import the compiler get 6.

Nobody noticed because no workflow runs `make ui-lint`. Wiring lint and
vitest into CI is a follow-up, not in here.

## Testing

```console
$ pnpm exec tsc --version
Version 7.0.2
$ pnpm lint
ESLint: 0 errors, 3 warnings in 2 files
$ pnpm build
✓ built in 491ms
$ pnpm test
 Test Files  10 passed (10)
      Tests  31 passed (31)
$ pnpm install --frozen-lockfile
Lockfile is up to date, resolution step is skipped
```

The 3 warnings are `react-refresh/only-export-components` in
`profile-form-fields.tsx` and `toast.tsx`. Pre-existing, just not
visible while the linter was dead.

## Notes for reviewers

- Editors that use the workspace TypeScript now get 6.0 for the language
service, the build still type-checks with 7.0. A mismatch between the
two would show up as "editor is fine, `pnpm build` fails" or the other
way round.
- Temporary by design. Once typescript-eslint supports the TS 7.1 API
(typescript-eslint/typescript-esl... (continued)

5182 of 6550 relevant lines covered (79.11%)

34.83 hits per line

Coverage Regressions

Lines Coverage ∆ File
4
78.37
0.0% pkg/controller/target_controller.go
Jobs
ID Job ID Ran Files Coverage
1 39226934676.1 97
79.11
GitHub Action Run
Source Files on build 39226934676