ben-manes / caffeine / #5831

100%

master: 100%

Build Type

push

github

Committed by ben-manes

Commit Message

register every refresh before calling its loader

Automatic refresh and the async view's refresh still called the loader
inside the refreshes computeIfAbsent, so an inline reload held its bin
for the whole load: a caller-runs executor, a synchronous asyncReload
prefix, or the Guava facade's default reload, which calls load, on any
executor. Two reloads that each read a stale key in the other's bin
deadlocked, where native Guava completes the same loader, and a slow
inline reload stalled every discard of a refresh registered in its bin,
including maintenance evicting such a key under the eviction lock.

These refreshes now publish a placeholder and call the loader after it
is registered, as LoadingCache.refresh does, so no loader runs under a
refreshes bin. A refresh through the async view that finds a placeholder
waits for and returns the loader's future.

Coverage Stats

4879 of 4890 branches covered (99.78%)

82 of 82 new or added lines in 3 files covered. (100.0%)

1 existing line in 1 file now uncovered.

9345 of 9350 relevant lines covered (99.95%)

1.0 hits per line