Mellanox
/
ovn-kubernetes
/
39178940322
59%
|
Ran
|
Jobs
1
|
Files
348
|
Run time
1min
|
Badge
Embed ▾
README BADGES
|
coverage: 59.276% (-0.02%) from 59.299%
push
github
aserdeanfeat: add option to disable SNAT on default gateway routers Add a new --disable-snat-gateway-routers CLI flag (env: OVN_DISABLE_SNAT_GATEWAY_ROUTERS) that disables default cluster-subnet SNAT rules on gateway routers for the default network. When enabled, OVN will not install SNAT rules that masquerade pod traffic behind the node's external IP on gateway routers. This is useful in deployments where pod CIDRs are externally routable (e.g., BGP-advertised) and SNAT would break return path routing. Changes: - config: add DisableSNATGatewayRouters bool to GatewayConfig and register the --disable-snat-gateway-routers CLI flag - gateway: skip NAT rule installation in updateGWRouterNAT when the flag is set on the default network; stale NAT entries are still cleaned up on upgrade - ovnkube.sh: wire OVN_DISABLE_SNAT_GATEWAY_ROUTERS into ovn-master, ovnkube-controller, ovnkube-controller-with-node, ovn-cluster-manager and ovn-node modes - tests: add gateway_test case verifying no SNAT rules are created when the flag is set; update master_test skipSnat logic to cover the new flag Signed-off-by: Hareesh Puthalath <hareeshp@nvidia.com> (cherry picked from commit d8e8aa510)
5 of 5 new or added lines in 1 file covered. (100.0%)
57 existing lines in 11 files now uncovered.56979 of 96125 relevant lines covered (59.28%)
315.19 hits per line
Coverage Regressions
| Lines | Coverage | ∆ | File |
|---|---|---|---|
| 24 |
49.62
|
-18.32% | go-controller/pkg/ovn/controller/network_qos/network_qos_namespace.go |
| 7 |
65.77
|
-1.26% | go-controller/pkg/ovn/controller/apbroute/external_controller.go |
| 6 |
80.19
|
-0.1% | go-controller/pkg/ovn/gateway.go |
| 4 |
84.9
|
-1.14% | go-controller/pkg/clustermanager/networkconnect/cluster_network_connect.go |
| 4 |
62.74
|
-1.1% | go-controller/pkg/ovn/controller/network_qos/network_qos.go |
| 3 |
78.07
|
-1.32% | go-controller/pkg/node/routemanager/route_manager.go |
| 2 |
86.89
|
1.17% | go-controller/pkg/clustermanager/managedbgp/controller.go |
| 2 |
79.13
|
-0.2% | go-controller/pkg/ovn/base_network_controller_policy.go |
| 2 |
60.78
|
-3.92% | go-controller/pkg/ovn/controller/apbroute/external_controller_pod.go |
| 2 |
67.37
|
-0.33% | go-controller/pkg/ovn/master.go |
| 1 |
75.06
|
-0.11% | go-controller/pkg/ovn/base_network_controller_pods.go |
Jobs
| ID | Job ID | Ran | Files | Coverage | |
|---|---|---|---|---|---|
| 1 | 39178940322.1 | 348 |
59.28
|
GitHub Action Run |
