thumbor / libthumbor / 39155158683

100%

push

github

Drop six and encode keys and URLs as UTF-8

CryptoURL converted a str key with six.b(), which encodes as latin-1, while
the Signer that thumbor itself imports from libthumbor.url_signers encodes
the same key as UTF-8. For any key containing non-ASCII characters the two
sides disagreed: CryptoURL("ação") produced a signature thumbor rejects, and
keys outside latin-1 raised UnicodeEncodeError in the constructor, as did
url_for() with a non-latin-1 image_url when hashing it with MD5. All str to
bytes conversions now use .encode("utf-8"), matching the signer, and six is
removed from the runtime dependencies since the project is Python 3 only.

Signatures for ASCII keys, which is every documented example, are unchanged
and the existing fixtures prove it. Signatures for keys with latin-1
characters outside ASCII change, but those were already incompatible with
the thumbor server, so no working deployment is affected. six remains in the
lock file as a transitive development dependency of preggy.

7 of 7 new or added lines in 3 files covered. (100.0%)

267 of 267 relevant lines covered (100.0%)

5.0 hits per line