source-academy / frontend / 39132462749

48%

push

github

fix: the Filter Arrows menu works in fullscreen mode (#4501)

* fix: the Filter Arrows menu works in fullscreen mode

Fullscreen mode (Workspace's .right-parent) draws only the fullscreen
element's subtree, and Blueprint overlays portal to document.body, so the
Filter Arrows popover opened invisibly. Portal it (and its tooltip) into the
current fullscreen element, as the Fullscreen button's tooltip already does.
Applies to the CSE Machine tab and to the environment view lent to web
plugins, e.g. the e-stepper.

Fixes #4500

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

* fix: the environment view's overlays follow fullscreen changes

The portal container was read only when CseEnvironmentView rendered, and its
host does not re-render it when fullscreen is entered or exited, so its
tooltip and an already-open Filter Arrows menu could keep a stale container.
Subscribe to fullscreenchange with a hook.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com>

3483 of 8170 branches covered (42.63%)

Branch coverage included in aggregate %.

7 of 7 new or added lines in 2 files covered. (100.0%)

7592 of 15102 relevant lines covered (50.27%)

45.75 hits per line