solidjs / solid / 39111900627

78%

main: 89%

push

github

fix(signals): a store key's delete decrements the key count (#4132)

* fix(signals): a store key's delete decrements the key count

`kc` gates the overlay draft (an owned plain object above 32 keys drafts
as an overlay over its committed backing) and caps the rebuild. The set
trap incremented it for every new key; nothing decremented it when a key
was deleted from a plain-clone draft, or when an overlay's own add was
deleted again — only the overlay rebuild paths subtracted their recorded
committed deletions. So the natural keyed-selection shape, "delete the
old key, set the new one", drifted the count up by one per write: after
32 selections a three-key object crossed the overlay threshold and, since
any delete makes an overlay rebuild its backing (#3689), every commit
after paid a full clone of the object — 1.4 µs of a 5.5 µs select on the
js-framework fixture, found while asking why Solid's keyed-store
selection cost three times Vue Vapor's compiled selector.

`deleteProperty` now decrements for an own key of the draft that leaves
(a clone's key, an overlay's own add) and leaves an overlay's committed
key to `del`, counted at the rebuild as before. Tests pin the selection
shape staying at two keys and out of overlay mode over 200 writes,
delete-and-re-add, delete of a never-committed key, and the overlay's two
delete cases; the overlay rebuild tests (#3689) pass unchanged.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

* size: raise the three store-bearing caps for the delete key-count fix; tighten the trap

+33 B minified on the createStore graph (one hasOwn probe hoisted, the
delete and the decrement share its verdict); caps at measured + 10 B
with a ledger line each (signals: + createStore 14.79 -> 14.82 KB,
app: hydrating + every store primitive family 30.09 -> 30.14 KB,
app: compiled CSR 25.95 -> 26.03 KB). Inline caps, not frozen floors.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

* size: raise the compiled hydratin... (continued)

756 of 1050 branches covered (72.0%)

Branch coverage included in aggregate %.

1097 of 1339 relevant lines covered (81.93%)

27.82 hits per line