astronomer / astro-cli / 39087643563

45%

push

github

Match the agent's settings namespace, and drop the remote deploy warning (#2351)

* Match the agent's settings namespace, and drop the remote deploy warning

The agent check matched ASTRO_AGENT_CLIENT_PROCESS_SPAWNER, the one
variable the published agent image (Dockerfile.standalone) sets; it
carries no label of its own. It now matches ASTRO_AGENT_CLIENT_, the
agent's whole settings namespace, so renaming one setting does not blind
the check.

astro remote deploy no longer warns about an image without the variable.
Were the agent image to stop setting it, that warning would fire on every
correct deploy, and it added little: the generated Dockerfile.client is
FROM the agent image, and the runtime check already reads its tag. The
hosted refusal stays; losing the variable only turns it off.

Also drops a doc comment left from #2226's first tests, and
captureStdout, which only the warning's test used.

Co-Authored-By: Claude <noreply@anthropic.com>

* Pin the agent prefix, and say how to get past a wrong refusal

TestAgentEnvVarPrefix checks the constant against the variable the published agent image sets, and against a near-miss: the other tests hand it to a mock, which takes any value. The refusal now names 'astro config set show_warnings false' for an image that is not an agent image, the one way past it.

Co-Authored-By: Claude <noreply@anthropic.com>

---------

Co-authored-by: Claude <noreply@anthropic.com>

6 of 6 new or added lines in 1 file covered. (100.0%)

27425 of 60591 relevant lines covered (45.26%)

9.97 hits per line