astronomer / astro-cli / 39079496860

61%

main: 45%

Build Type

push

github

Committed by web-flow

Commit Message

Merge main into v2 (#2344)

* Name the right config in the unconfigured-registry advice, and keep TestClientRegistry from leaking (#2341)

* Point the unconfigured-registry error at -g, and keep TestClientRegistry from leaking

Follow-up to #2224, from a code review of its v2 sync (#2339):

- "remote client registry is not configured" told the user to run
  `astro config set remote.client_registry <endpoint>`, which outside
  a project saves nothing and still reports success, so the next
  deploy failed the same way. It says -g now, as ClientRegistry's own
  error does.
- TestClientRegistry restores the home config's remote.client_registry
  it changes, so a later test does not depend on running after it.
- Its project-scope check asserted no "-g" anywhere in the error, which
  an endpoint containing "-g" would break; it looks for the -g command.

Co-Authored-By: Claude <noreply@anthropic.com>

* Pick the registry fix command by scope, and restore the configs TestClientRegistry replaces

The unconfigured-registry error always said -g, which is wrong when the
project sets remote.client_registry to "": that shadows the global value,
so setting it globally changes nothing. config.ClientRegistryFix picks the
command by the same rule ClientRegistry's own error uses, and both read it
from one place.

TestClientRegistry's cleanup read the value after initTestConfig had
already replaced the home config, and wrote it back as a saved key. It now
saves and restores the viperHome and viperProject it replaces.

The deploy test now asserts the -g command itself.

Co-Authored-By: Claude <noreply@anthropic.com>

---------

Co-authored-by: Claude <noreply@anthropic.com>

* Restore all of config's globals in TestClientRegistry on v2

On v2, InitConfig also swaps configFs and edits unreadableConfigs, so
restoring only viperHome and viperProject still leaked. Use
restoreConfigGlobals, which puts back all of them.

The deploy test asserts config.ClientRegistryFix() rather... (continued)

Coverage Stats

12 of 12 new or added lines in 2 files covered. (100.0%)

1 existing line in 1 file now uncovered.

40383 of 67251 relevant lines covered (60.05%)

292.71 hits per line