astronomer / astro-cli / 39068171925

45%

Build Type

push

github

Committed by web-flow

Commit Message

Stop standalone Airflow's whole process group, sign with a random secret, and warn when it's open to the network (#2222)

* Bind standalone Airflow to loopback and stop the whole process group

Standalone mode sets SIMPLE_AUTH_MANAGER_ALL_ADMINS=True while Airflow's
api-server/webserver default to binding 0.0.0.0, so a local dev instance
was reachable from other machines on the network. BuildEnv now defaults
AIRFLOW__API__HOST (Airflow 3) and AIRFLOW__WEBSERVER__WEB_SERVER_HOST
(Airflow 2) to 127.0.0.1. A user's own setting, from .env or the
inherited environment, still wins; only the default changed.

StopProcess polled the master PID, which often exits on SIGTERM before
its scheduler/api-server/triggerer children, so those children survived
astro dev stop. It now polls the process group and only returns once the
whole group is gone, escalating to SIGKILL on timeout as before.

The signal helpers are now vars so tests can stub them; the stop path is
covered without real processes.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01P6DEdUpFBFaAiPKEu81Wti

* Apply the loopback and process-group fixes to the live standalone paths

Review found that airflowrt.BuildEnv and airflowrt.StopProcess have no
production callers: astro dev start/stop run (*Standalone).buildEnv and
(*Standalone).Stop in airflow/standalone.go, which still bound 0.0.0.0
and still polled only the master PID. This wires the fixes into those
paths.

airflowrt now exports ApplyLoopbackDefaults, which both its own BuildEnv
and standalone.go's buildEnv call, so the two host keys are defined once.
It also exports ProcessGroupAlive; standalone.go's Stop polls it instead
of re-reading the master PID. The master is the group leader (Start sets
Setpgid), so kill(-pid, 0) is a valid group probe.

Live-path tests: buildEnv loopback defaults plus .env and inherited-env
overrides, and a Stop test that starts a real process group whose master
di... (continued)

Coverage Stats

98 of 113 new or added lines in 1 file covered. (86.73%)

1 existing line in 1 file now uncovered.

27341 of 60482 relevant lines covered (45.21%)

9.97 hits per line