agronholm / anyio / 39059961158

92%

push

github

Shield TemporaryDirectory.cleanup() from cancellation (#1316)

TemporaryDirectory.cleanup() ran the synchronous cleanup via to_thread.run_sync, which performs a cancellation checkpoint on entry. If the host task was already cancelled when cleanup() was called (as it normally is, from a finally block), that checkpoint aborted the cleanup before the worker thread ran, leaking the temporary directory.

#1304 fixed this same failure in __aexit__ by wrapping the call in a shielded CancelScope, but left cleanup() with the identical bug a few lines below. Apply the same fix to cleanup(), and add a regression test mirroring the one #1304 added for __aexit__.

---------

Co-authored-by: Alex Grönholm <alex.gronholm@nextday.fi>

3 of 3 new or added lines in 1 file covered. (100.0%)

6907 of 7528 relevant lines covered (91.75%)

11.71 hits per line