astronomer / astro-cli / 39053272898

61%

main: 45%

push

github

Push images through pkg/imagebuild and delete internal/imagepush (#2327)

* Push images through pkg/imagebuild and delete internal/imagepush

Every image action now runs in pkg/imagebuild on one engine runner.
imagebuild.Engine (the Commander, Bin and Env a build takes) logs in with
the secret on stdin, tags, pushes (returning the pushed digest: Docker's
RepoDigests, or podman's --digestfile), untags and reads labels, and maps
a registry 403 to ErrPushForbidden, whose text is the old ErrImagePush403's.

The Astro manifest deploy pushes and reads labels on the engine it built
on; astro remote deploy resolves one engine for its base-registry login,
build and push; the APC deploy and the APC registry login run on
containercfg.ImageEngine. So a project-level container.binary and a podman
machine's connection env now reach the login and the push too, not just
the build. The Docker Engine API push and its CLI fallback are replaced by
the engine CLI's push, the old fallback's path.

internal/imagepush, its mocks, its .mockery.yaml and archlint entries go;
go mod tidy drops docker/cli with it.

Co-Authored-By: Claude <noreply@anthropic.com>

* Read a refused push from the engine's output, not the reference

Review fixes for the imagebuild push:

- A 403 is read from what the engine said (its stderr and exit), with the
  pushed reference cut out, so a tag such as deploy-403 is not a refusal.
- A login before a push that the registry refuses (401, unauthorized,
  incorrect username or password, authentication required) is
  ErrPushForbidden too, wrapping the engine's failure.
- ErrPushForbidden's text is platform-neutral; the CLI's advice (docker
  logout, the snapshotter, the support article) moves to
  deploybuild.ExplainPush, which every deploy's push error goes through,
  so the message a user sees is unchanged.
- The Astro manifest deploy sends the push's progress to in.Progress, not
  stdout, so --output json's stdout carries the result alone.
- APC 1.0+ ... (continued)

90 of 105 new or added lines in 7 files covered. (85.71%)

40321 of 67189 relevant lines covered (60.01%)

292.82 hits per line