astronomer / astro-cli / 39052759557

45%

push

github

PINF-703 add token login support to autheticate with token passing (#2157)

* add token login support to autheticate with token passing

* fix pre-commit and linting

* Keep a working APC login when --token-login is refused, clean the token, and test the token path

From a code review of this PR:

- A token given with --token-login was saved to the context before
  Houston had seen it, so an expired or mistyped one failed the login
  and also replaced the working token, and every command after it
  failed. The Houston client reads the token from the context, so it
  is still saved before the first request (listing workspaces), but
  the previous token is put back if that request fails.
- The token is trimmed and a "Bearer " prefix dropped: the Houston
  client adds its own, and a token read from a file carries a newline.
  A token that is empty after that is an error rather than a fall back
  to the interactive login.
- The interactive flow no longer hands Login an empty token: with
  basic auth disabled, a username yielded "" and no error, and Login
  saved it over the login there was. That predates this PR.
- --token-login and --oauth are mutually exclusive: a token login asks
  for nothing, so --oauth was silently ignored. --token-login's help
  no longer says it is for Astro only.
- Tests: Login with a given token saves it cleaned, without fetching
  the auth config; a refused one leaves the previous token; a blank one
  is refused before anything is asked; resolveAuthToken refuses an
  empty interactive token; the cmd layer hands --token-login to the APC
  login, with a domain and without; --token-login with --oauth is
  refused.

Co-Authored-By: Claude <noreply@anthropic.com>

---------

Co-authored-by: Greg Neiheisel <greg@astronomer.io>
Co-authored-by: Claude <noreply@anthropic.com>

37 of 41 new or added lines in 2 files covered. (90.24%)

27234 of 60393 relevant lines covered (45.09%)

9.83 hits per line