tari-project / tari / 38929947603

77%

Build Type

push

github

Committed by web-flow

Commit Message

refactor(covenants): defer token parsing and bound evaluation work (#8131)

Covenants now keep their canonical encoded bytes and are tokenized when
evaluated. Decoding enforces a total token limit across nesting levels
and minimal length prefixes. Covenant evaluation per body has a fixed
work limit, caches output hashes, and requires each covenant to be
satisfied by a distinct output. Covenant checks run before range-proof
verification. Gossiped transactions whose covenants exceed the token
limit are treated like other malformed gossip from a peer. These rules
only apply to non-empty covenants, which public networks do not permit.

## Changes
- `Covenant` stores its canonical bytes plus the top-level token count;
a decode-time scanner validates and canonicalises, and tokens are built
on demand for evaluation. Encoded bytes, hashing, weight and serde/borsh
output are unchanged for every covenant accepted before.
- `MAX_COVENANT_TOKENS` (128) now bounds tokens across all nesting
levels.
- Length varints inside covenants must be minimal.
- `MAX_COVENANT_WORK_PER_BODY` (250,000) bounds evaluation per aggregate
body; output hashes are cached per body.
- Each output can satisfy at most one input's covenant (greedy
assignment, with a bipartite matching fallback so the result does not
depend on ordering).
- Covenant validation moved ahead of the kernel sum, range proofs and
scripts.
- DHT gossip: a transaction whose covenant exceeds the token limit gets
a Long ban of the sending peer (same helper and relay handling as the
existing gossip ban). Mempool sync and RPC reject it without a ban.

## Testing
- `cargo ci-check` and release nextest for
`tari_transaction_components`, `tari_core`, `minotari_app_grpc` and
`minotari_wallet_ffi`: 1406 passed, 18 skipped.
- New tests: decode heap bound (counting allocator), total token
boundary, canonical byte equivalence, minimal length prefixes, work
limit, hash cache, claim-once and order independence,
covenant-before-ran... (continued)

Coverage Stats

809 of 829 new or added lines in 31 files covered. (97.59%)

2228 existing lines in 43 files now uncovered.

135214 of 177689 relevant lines covered (76.1%)

398903.73 hits per line