MONEI / dynamoose / 38903598394

99%

main: 99%

Pull #30

github

fix(model): refuse a nested $REMOVE under a parent with its own set or validate rule

A nested $SET under such a parent is refused (refuseRuleOnPartialObject):
the rule cannot vet a partial object. A removal is a partial write too, but
it carries no value, so it never reached that check. Both

  {"$REMOVE": ["a.b"]}
  {"$SET": {"a.b": undefined}}

were sent with the parent's validate or set never applied, which let a
caller skip the rule by spelling the write as a removal.

refuseRemoveUnderRuleAncestor refuses both before the expression is built.
The ancestor's rule is read with returnFunction, never run: calling it would
invoke a user function with no value.

Also drops an unreachable fallback in the combine-key branch, keeping the
file identical to upstream-pr/feat-update-nested-paths.

1836 of 1876 branches covered (97.87%)

Branch coverage included in aggregate %.

15 of 16 new or added lines in 1 file covered. (93.75%)

3357 of 3377 relevant lines covered (99.41%)

37013.72 hits per line