nottinghamtec / PyRIGS / 38890779038

91%

Build Type

push

github

Committed by web-flow

Commit Message

Add section headers to event items, and make the item editor less fiddly (#689)

* Add section headers to event items

Items can now be marked as section headers (#190): a title-only row with no
price or quantity. Each section shows a total for the items beneath it, up to
the next header, and gets its own pastel hue.

Sections don't affect event totals. The printed paperwork shows them as a
tinted band with a "<name> sub-total" row after the section's last item.

* Section editing and item editor improvements

Add the section header option to the item editor, with live section totals,
per-section colours and indentation of the items beneath each header.

Also make editing items less fiddly:
- click a name, price, quantity or description to edit it in place
- duplicate button on each row
- focus the name field and add a "Save & add another" button in the modal
- replace html5sortable with a handle-based drag that moves the row itself,
  so it always lands where it was last shown
- undo bar after deleting an item
- warn before leaving the page with unsaved changes

interaction.js is loaded by other forms, so it now does nothing without an
item table.

* Make the empty crew record row readable in dark mode

bg-warning gave white text on bright yellow. Use the theme-aware
table-warning row style instead.

* Split Add Item into Add Item and Add Section

Sections are now added with their own button, and the item modal adapts to
the type (no price or quantity fields for a section) instead of using a
checkbox.

* Fix markdown editor toolbar and preview in dark mode

EasyMDE's toolbar buttons are <button>s now, so the dark theme's rules for
<a> toolbar items no longer applied: hovered and active buttons went white
with white icons. The preview pane was also white with near-white text.
Style the buttons and preview for dark mode.

* Fix inline description edits not applying

Editing a description inline replaced the markdown element inside its box,
so redrawing... (continued)

Coverage Stats

38 of 44 new or added lines in 2 files covered. (86.36%)

1 existing line in 1 file now uncovered.

4138 of 4718 relevant lines covered (87.71%)

0.88 hits per line