xapi-project / xen-api / 38889157990
79%
master: 79%

LAST BUILD BRANCH: typed-vm-lifecycle-messages
DEFAULT BRANCH: master
Ran
Jobs 1
Files 36
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 78.996%. Remained the same
38889157990

push

github

web-flow 
CP-314452: xenopsd: enable kTLS migration from the migration_ktls experimental feature flag (#7337)

Currently, xenopsd only uses kTLS for the migrations that a host sends
when its xenopsd.conf sets migration-tls = "ktls".
`xe-enable-experimental-feature migration_ktls`, the way the plans in
doc/content/design/migration-tls.md (R1.1.1) say a host should opt in,
currently has no effect.

This PR enables kTLS for the the migrations when that host's
migration_ktls experimental feature is on, while an explicit
migration-tls in xenopsd.conf still overrides the decision on that host.
xenopsd now chooses the transport once per https migration: a) an
explicit migration-tls in xenopsd.conf wins; b) otherwise kTLS is used
if /etc/xenserver/features.d/migration_ktls is on (1 or true), else c)
stunnel stays the default. An unusable file or an unrecognised value
means stunnel, with a warning. The choice is logged with what made it
and used for the vm, mem and vgpu connections of a migration. The flag
is read with a new Unixext.read_small_regular_file, which never blocks
on a FIFO or a device, reads a bounded amount and never raises; the
design document, the sample xenopsd.conf and the helper's docs are
updated.

Tested with:
* positive: with `xe-enable-experimental-feature migration_ktls` on both
hosts, every migration logged "migration-tls: ktls (from
/etc/xenserver/features.d/migration_ktls)" and used kTLS (2 kTLS sockets
each, no fallback to stunnel): test job 4760693 (10-VM pool-master
evacuation), and manual migrations in both directions, also tested with
zstd compression on.
* regression: BVT 252229, BST 252230 found no regressions. Every https
migration sent by this build logged the expected line "migration-tls:
stunnel (from /etc/xenserver/features.d/migration_ktls)", indicating no
change of behaviour in the default case. XS8->XS9 migrations and the
rolling upgrade from XS8 worked as expected.

3667 of 4642 relevant lines covered (79.0%)

0.79 hits per line

Jobs
ID Job ID Ran Files Coverage
1 python3.11 - 38889157990.1 36
79.0
GitHub Action Run
Source Files on build 38889157990