stacklok / toolhive / 38864104745

71%

Build Type

push

github

Committed by web-flow

Commit Message

Grant pods/attach only for stdio transport (#6841)

* Grant pods/attach only for stdio transport

The proxy-runner Role created for every MCPServer carried
pods/attach (create, get) regardless of transport. Only stdio
uses it: the runner reaches a stdio MCP server by attaching to
its pod through Client.AttachToWorkload, which is called only
from pkg/transport/stdio.go. A streamable-http or sse server
talks to its pod over the network and never attaches.

Security auditors flag pods/attach as equivalent to pod exec,
so clusters with strict policies saw a finding on every
MCPServer deployment for a permission that could not be used.

Split the rule out of defaultRBACRules into stdioRBACRules and
choose between them in rbacRulesForTransport. An absent
transport is treated as stdio, matching the CRD default, so an
object stored before that default existed keeps working.

Already-deployed servers are corrected without operator action:
EnsureRBACResources replaces Rules wholesale, so the next
reconcile rewrites the Role.

Closes #6230

Signed-off-by: hellouz818 <hellouz818@gmail.com>

* Split proxy-runner Role fixtures by transport

The chainsaw operator E2E suites asserted one shared
proxyrunner-role.yaml for the stdio, sse, streamable-http and
stdio-streamable-http scenarios. That stopped holding once
pods/attach became transport-dependent: chainsaw matches the
rules array positionally and on length, so the stdio scenarios
failed on the rule having moved to the end, and the HTTP ones
would fail on it being absent.

Replace the shared file with proxyrunner-role-stdio.yaml (six
rules, pods/attach last) and proxyrunner-role-http.yaml (the
five shared rules), and point each scenario at the one matching
the transport in its mcpserver.yaml. Both files still spell out
the complete expected Role, so an over-granted rule fails the
assertion rather than slipping through.

Only the multi-tenancy run reached CI: chainsaw runs with
FailFast and both suites share one s... (continued)

Coverage Stats

6 of 6 new or added lines in 1 file covered. (100.0%)

19 existing lines in 5 files now uncovered.

87199 of 122234 relevant lines covered (71.34%)

126.43 hits per line