opendefensecloud / solution-arsenal / 38852449595
80%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 97
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 79.053% (-0.06%) from 79.115%
38852449595

push

github

web-flow 
fix(ui): require namespace selection in create dialogs in all-namespaces view (#872)

## What
In the "All namespaces" view, the Target and Profile create dialogs now
require picking a namespace instead of silently creating into `default`.
Closes #820

## Why
Both list pages passed `namespace ?? 'default'` into their create
dialog. "All namespaces" is the default view for anyone allowed to list
cluster-wide, so resources ended up in `default`, with an empty release
list and, for users without access to `default`, a 403 only after
filling in the whole form.

## Testing
- Unit: added "All namespaces" tests per dialog (namespace picker is
shown, submit without a namespace shows "Namespace is required.", the
picked namespace reaches the create/bind mutations, switching namespace
clears an already selected registry/releases); `pnpm test` passes
(36/36) and `tsc` is clean. Verified the namespace test fails when the
`'default'` fallback is put back.
- Manual against the `solar-ui-dev` Kind cluster (`make ui-dev` + `make
ui-seed-data`), logged in as `admin@solar.local` on "All namespaces":
- New Target / New Profile show a Namespace dropdown instead of
"Creating in namespace default".
- Create without a namespace shows the validation error and sends no
request.
- After picking `k8s-cluster-provider`, the render-registry suggestions
and the release list fill in for that namespace (they also update live
when data is seeded while the dialog is open).
- With a specific namespace selected in the sidebar, both dialogs behave
as before ("Creating in namespace X", no dropdown).

## Notes for reviewers
- New shared `NamespacePickerField`
(`web/src/components/namespace-picker-field.tsx`) renders either the
fixed-namespace hint or a required picker; both dialogs now take
`namespace: string | null`.
- Registry and release queries in the dialogs are disabled until a
namespace is chosen, and changing the picked namespace clears an already
selected registry/releases, since t... (continued)

5178 of 6550 relevant lines covered (79.05%)

33.4 hits per line

Coverage Regressions

Lines Coverage ∆ File
4
77.99
-0.19% pkg/controller/target_controller.go
2
76.56
-0.73% pkg/controller/helpers.go
Jobs
ID Job ID Ran Files Coverage
1 38852449595.1 97
79.05
GitHub Action Run
Source Files on build 38852449595