curationexperts / laevigata / 2ac856e9-6a47-48ff-afa2-4a7d10ab77cf

97%

main: 97%

Build Type

Pull #2557

circleci

Committed by mark-dce

Commit Message

Fix RegistrarFeed 500 errors

**ISSUE**
Admins are getting 500 errors after uploading new Registrar Feed files.

**DIAGNOSIS**
After upload, the `RedistrarFeed` controller redirects to the index
view, which includes the call:
```
dasher(registrar_feed.published_etds+registrar_feed.graduated_etds)
```

Both `published_etds` and `graduated_etds` are nil until the
`GraduationService` has completed running. So, while the feed is
`queued` or `working`, we get an "undefined method '+' for nil" error.
This appears as a 500 error in the administrators browser.

**RESOLUTION**
Add a short instance method to the class that guards against the
nil case until the two counts are saved.

Pull Request Pull Request #2557: Fix RegistrarFeed 500 errors

Coverage Stats

3 of 3 new or added lines in 1 file covered. (100.0%)

35 existing lines in 9 files now uncovered.

2784 of 2856 relevant lines covered (97.48%)

49.9 hits per line