gookit / color / 38841782143

99%

push

github

fix(convert): reject signed hexadecimal RGB color values (#124)

HexToRgb parsed the normalized 6-char value with strconv.ParseInt(hex, 16, 32), so a signed input such as -00001 was accepted as a colour -- rgb [-1 255 255] -- and HEX() rendered it as white instead of an empty colour. Parse it as an unsigned 24-bit value instead: that rejects a leading + / - and cannot overflow for a 6-digit input (0xFFFFFF fits in 24 bits exactly), so no legitimate colour changes.

CI on the PR (Go 1.18-1.20 x linux/macOS/windows, CodeQL, Codacy) was green; the signed-value regression was re-verified locally against master before merging.

2 of 2 new or added lines in 1 file covered. (100.0%)

1488 of 1509 relevant lines covered (98.61%)

8.57 hits per line