NVIDIA / nvidia-container-toolkit / 38820334663

45%

main: 45%

push

github

Do not read NVIDIA_IMEX_CHANNELS=none as a request for every channel

devicesFromEnvvars routes the value through NewVisibleDevices, and the none
sentinel reports itself as a single empty ID, so imexChannelsFromEnvVar hands
back []string{""} rather than nothing. imexDevices.DeviceRequests turns that
into the request

  mode=imex,id=

and cdiModeIdentfiersFromDevices drops an empty id while still recording the
mode, so GetSpec is called for mode imex with no IDs at all. An empty ID list
is what GetSpec reads as "all", so getAllChannelIDs discovers every
/dev/nvidia-caps-imex-channels/channel* under the dev root and fromCDISpec
applies the edits of each one. A container that asked for no IMEX channels
gets all of them.

The visible-devices path guards against the same artefact already:
cdiDeviceRequestor.DeviceRequests turns the empty ID back into "none" before
building its request, which is what #1562 fixed for issue #1555. There is no
"none" IMEX channel to fall back to, so the request list should be empty.

Treat the empty ID the way the legacy "all" default beside it is already
treated. The legacy hook path does not change: there the single empty ID
joins to "" and no --imex-channel flag is passed.

Signed-off-by: Dmitry Voropaev <dy.voropaev@gmail.com>

2 of 2 new or added lines in 1 file covered. (100.0%)

6055 of 13558 relevant lines covered (44.66%)

0.45 hits per line