eclipse-aascw / aas-core-codegen / 38814276020

90%

Build Type

push

github

Committed by web-flow

Commit Message

Make read-only sequences of verifications generic (#852)

We make the read-only ``Sequence[...]`` arguments of the verification
functions generic if their items are instances of a class with
descendants. This way, the sequences of the descendants can be passed
without a copy, as aas-core-meta V3.2 does, *e.g.*, in
``ID_shorts_are_unique(self.submodel_elements)``.

Go declares a type parameter, *e.g.*, ``func IDShortsAreUnique[
ReferablesT ourtypes.IReferable](referables []ReferablesT)``, C++
a template defined in the header, C# the covariant
``IReadOnlyList<T>``, and Java the wildcard ``List<? extends T>``.
Python and TypeScript accept the sequences of the descendants already.

The methods stay invariant, since Go methods can not have type
parameters and C++ virtual methods can not be templates, and so do
the mutable ``List[...]`` arguments. The type inference now checks
the items of all the list arguments, and restricts the usages of
the generic sequences, *e.g.*, they can not be passed to a method.

We support ``in`` on the generic sequences with the new
``ourcommon.SliceContainsInstance`` in Go, and the immutable aliases,
*e.g.*, ``alias: Final[Sequence[Item]] = items``, which C# and Java
now declare with ``var``.

We test all this in the new common meta-model
``variance_of_containers``.

Coverage Stats

338 of 354 new or added lines in 11 files covered. (95.48%)

1 existing line in 1 file now uncovered.

45910 of 50905 relevant lines covered (90.19%)

2.71 hits per line