openconfig / kne / 38805668205

48%

push

github

topo/node: disable Kubernetes service links on node pods (#789)

Kubernetes injects <SVC>_SERVICE_HOST / <SVC>_PORT_* environment
variables into every container for each Service in the namespace
(enableServiceLinks defaults to true). KNE creates one Service per node,
so the environment of every node container grows linearly with topology
size: ~20k variables, ~0.9 MB per container at 1000 nodes.

In large topologies this slows shell-based init in network OS images
(every fork copies the environment), contributes to host-wide contention
when many nodes boot per worker, and causes E2BIG in scripts that lower
the stack ulimit.

Set EnableServiceLinks to false on every node PodSpec KNE builds
directly (generic, Cisco, Juniper, Alpine, SONiC, Forward, Ciena).
KUBERNETES_SERVICE_HOST/PORT are still injected. Nodes whose pods are
built by external operators (Arista, Nokia, Keysight, lemming) are
unchanged.

7 of 7 new or added lines in 7 files covered. (100.0%)

7073 of 14794 relevant lines covered (47.81%)

0.54 hits per line