optimizely / php-sdk / 38799749624

97%

push

github

[FSSDK-13266] Update dependency constraints for json-schema and murmurhash (#298)

* [FSSDK-13266] Update dependency constraints for json-schema and murmurhash

Allow justinrainbow/json-schema v6.x and lastguest/murmurhash v2.x
to support newer versions of these dependencies.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* [FSSDK-13266] Fix compatibility with murmurhash v2 and json-schema v6

murmurhash v2 removed the global murmurhash3_int() function in favor of
a static class method. Add a function_exists() check to support both APIs.

json-schema v6 deprecated check() in favor of validate(). Switch to the
new method for forward compatibility.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* [FSSDK-13266] Fix: Add check() fallback for older json-schema versions

validate() does not exist in json-schema v1.6 and v2.x. Use
method_exists() to call validate() when available and fall back
to check() for older versions.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* Add latest dependency CI coverage

Co-authored-by: Tamara-Barum <88795935+Tamara-Barum@users.noreply.github.com>

* Limit permissions for dependency CI job

Co-authored-by: Tamara-Barum <88795935+Tamara-Barum@users.noreply.github.com>

* [FSSDK-13266] Address PR review feedback

- Fix Validator.php comment to accurately describe json-schema version
  history (validate() added in v5, check() deprecated in v6)
- De-duplicate bitmask operation in Bucketer.php
- Change murmurhash constraint from ^2.0 to ^2.1 (2.0.0 requires PHP 7)
- Regenerate composer.lock to match updated constraints
- Remove premature CHANGELOG 4.0.4 entry (belongs in release-prep PR)
- Add CI job to test with latest dependency versions (PHP 8.1 + 8.2)
  with version assertion to verify v6/v2 actually resolved
- Add edge-case bucketing test keys (empty string, UTF-8)

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* [FSSDK-13266] Fix: Split composer show into separate commands

comp... (continued)

3 of 4 new or added lines in 1 file covered. (75.0%)

2706 of 2781 relevant lines covered (97.3%)

109.29 hits per line