emlove / jsonrpc-websocket / 38798313195

100%

push

github

Detach the websocket client before closing it (#23)

close() cleared self._client only after awaiting the client's close().
With an external session and a running reader, the close() called from
_ws_loop's finally block does the close handshake, and once that
finished it set self._client to None whatever it held by then, so a
ws_connect() made in the meantime lost its new client: connected went
False and the new socket stayed open.

Detach the client, and an internal session, in close() before awaiting
anything, and bind _ws_loop to the client it was started for. The
reader calls close() only while its client is still the current one,
otherwise it just finishes closing its own client and leaves a
replacement connection and its session alone. This also keeps the
reader from iterating None when close() finishes before it has
started, and a reader cancelled while closing no longer leaves
connected stuck at True, which made ws_connect() refuse to reconnect.

19 of 19 new or added lines in 1 file covered. (100.0%)

119 of 119 relevant lines covered (100.0%)

4.96 hits per line