veeso / suppaftp / 38797136541

92%

push

github

fix: block on the accepted active mode data connection (#202)

* fix: block on the accepted active mode data connection

In active mode the blocking client listens on a non-blocking socket so the accept loop can time out. On macOS and Windows the accepted data connection inherited that mode, so a server that was slow to send or receive data made the transfer fail at once with BadResponse or WouldBlock. The accepted connection is now switched back to blocking before the transfer and any TLS handshake. Linux was not affected.

Tests with a slow fake server cover listing, download and a large upload, and a new CI job runs the server-free active mode tests on Windows and macOS.

Pin just in every setup-just step, since zizmor flags an unpinned tool version.

closes #200

* ci: pin rust-toolchain action to the commit of its v1 tag

The pinned commit did not match the v1 tag named in the version comment. The action is now pinned to the commit that the v1 tag points to.

82 of 84 new or added lines in 1 file covered. (97.62%)

10299 of 11227 relevant lines covered (91.73%)

180300.24 hits per line