penguinolog / urwid / 38781725636

90%

master: 92%

push

github

Fix event loop callback races and idle handling

Callbacks that change loop state, failing callbacks and clock steps
left event loops crashed, stalled or busy.

- Idle callbacks may add or remove idle callbacks (all loops iterated the live dict).
- GLib and Twisted keep scheduling idle passes after an idle callback raises.
- GLib and Tornado stop the loop on ExitMainLoop or an error from an idle callback.
- Twisted logs a callback error when it does not manage the reactor, instead of printing it.
- ZMQ stops on a failing async callback without waiting for garbage collection.
- The fallback screen loop keeps alarms queued, so input can add earlier ones or remove them.
- asyncio and Trio remove_alarm() return False for an alarm that has fired.
- GLib, Tornado, Trio and Twisted replace an existing watch on the same descriptor.
- A Trio watch removed by a task woken in the same batch no longer runs its callback.
- Select and ZMQ alarms use the monotonic clock.
- Trio wakes the loop when an idle pass starts tasks, through its own socket pair.
- Trio runs idle callbacks after real work only: tasks started or woken by idle work,
  in any urwid loop of the Trio run, count only once I/O, a deadline or real work wakes them.

4973 of 5728 branches covered (86.82%)

Branch coverage included in aggregate %.

137 of 143 new or added lines in 8 files covered. (95.8%)

12520 of 13775 relevant lines covered (90.89%)

14.3 hits per line