binbashar / leverage / 38777620395

66%

Build Type

push

github

Committed by web-flow

Commit Message

Fix | Credentials configure fails when run after project init (#327)

* Fix | Skip PathsHandler for credentials configure during project bootstrap

leverage credentials configure crashed with "Project name has not been
set" when run right after `leverage project init` and before `leverage
project create`, since only project.yaml exists at that point (neither
build.env nor config/common.tfvars do yet) and PathsHandler can't
resolve a project name from either.

leverage project init/create already skip PathsHandler unconditionally
and need no change. For credentials configure, the top-level group
callback now skips PathsHandler only in that specific corner case, and
the credentials group callback (which already had a half-implemented
branch for this exact scenario) writes build.env from project.yaml's
short_name and builds real, project-scoped paths itself, so AWS
credentials still land in ~/.aws/<project>/ instead of falling back to
the global default location.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

* Fix | Stop AWS CLI probes from crashing credentials configure

`leverage credentials configure --type BOOTSTRAP` crashed with
"Command execution failed: The config profile (...) could not be
found" on a first-ever run, because `_profile_is_configured` calls
`Runner.exec(...)` without `raises=False`. `Runner.exec` defaults to
raising an ExitError on any nonzero exit code, so the intended
"probe, then report" logic (`return not exit_code`) never runs when
the profile has never been configured (exit 255) - it aborts the
whole command instead.

This is a regression from the Docker-removal refactor (#316), which
replaced the old non-raising `_exec` with the new `Runner`/`Runner.exec`
(raises by default) without updating call sites written for the old
contract. Six more `awscli.exec(...)` calls in credentials.py had the
identical shape; `_credentials_are_valid` and `_get_organization_accounts`
had real dead graceful-fallback logic, while `_ge... (continued)

Coverage Stats

532 of 1040 branches covered (51.15%)

Branch coverage included in aggregate %.

30 of 33 new or added lines in 4 files covered. (90.91%)

93 existing lines in 6 files now uncovered.

2828 of 4048 relevant lines covered (69.86%)

0.7 hits per line