datatug / datatug-cli / 38770366898
100%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 481
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 99.998% (+0.001%) from 99.997%
38770366898

push

github

web-flow 
fix(daemon): scrub the detached server's environment; never echo flag values in warnings (#397)

Security follow-up to #394/#396 (reported by the mods session).

1. **Warning no longer echoes a flag value.** The `--from`→`--client` rename (#396, merged) already stops `db copy --from <URL>` from being read as a caller; additionally the unknown-`--client` warning now never repeats the value (a connection URL typed into the wrong flag would otherwise reach stderr).
2. **Scrubbed child environment.** The detached `serve` child used to inherit the caller's whole environment (e.g. `DATATUG_OPEN_DB`) and hold it for up to 2h, visible to `ps eww`. It now gets an allow-list only (`PATH`, `HOME`, locale/XDG/TMP, Windows system vars, and the non-secret `DATATUG_{DAEMON,EVIDENCE,POLICIES,PERSONAL}_DIR`). New REQ `scrubbed-environment` in the daemon spec.

Tests: spawned helper process reports its env into the log and the test asserts `DATATUG_OPEN_DB`/the password are absent and allow-listed vars present; `scrubbedEnv` unit test; commands tests: `db copy --from <credentialed URL>` prints nothing and spawns nothing, `query run --from T` with `DATATUG_CLIENT=claude-mod` still ensures the daemon, a credentialed URL passed as `--client` is not echoed. 100% coverage kept.

Source commits:

- ff41bd441b19 fix(daemon): scrub the detached server's environment; never echo flag values in warnings
- 5441a93b7eb8 fix(daemon): keep telemetry opt-outs and directory overrides in the child environment

Pull request: datatug/datatug-cli#397
Review: https://github.com/datatug/datatug-cli/pull/397#issuecomment-6197066020

60395 of 60396 relevant lines covered (100.0%)

1.01 hits per line

Jobs
ID Job ID Ran Files Coverage
1 38770366898.1 481
100.0
GitHub Action Run
Source Files on build 38770366898