uber / h3 / 38757368281

100%

push

github

gridRing: validate k before wiping the output array (#1235)

gridRing wiped the caller's array with a width of 6 * k before any domain
check ran, so a negative k became a size_t of about 1.8e19 and the memset
ran off the end of the buffer (AddressSanitizer: negative-size-param,
size=-48). The width now comes from maxGridRingSize, which rejects a
negative k with E_DOMAIN and computes the size in int64_t. Every k the
function previously handled wipes the same width as before.

1929 of 1939 branches covered (99.48%)

Branch coverage included in aggregate %.

4 of 4 new or added lines in 1 file covered. (100.0%)

3421 of 3424 relevant lines covered (99.91%)

36976086.38 hits per line