elixir-gettext / gettext / 62f66fcadd834460a755963c7cc1b6d15038639c-PR-446

94%

main: 94%

Build Type

Pull #446

github

Committed by oliver-kriska

Commit Message

Store translations without interpolation in a literal map

Backends generate one function clause per translation, and the Erlang
compiler spends most of a backend's compile time optimizing the huge
functions this produces: on a catalog with 176 PO files and 73k
translations, a forced compile took 181 s of CPU, 87% of it in the Erlang
compiler's SSA passes. Translations that need no interpolation have nothing
to compile, so keep them in a literal map that the catch-all clause of the
singular lookup function searches instead of generating a clause for each.
Messages with interpolation and plural messages keep their clauses, and
backends with a custom interpolation module keep the previous code
generation, since whether a translation needs interpolation depends on the
interpolation syntax.

On that catalog a forced compile goes from 204 s to 60 s wall (181 to 57 s
CPU, 4.8 to 2.5 GB) for a single module and from 26 s to 8 s (249 to 67 s
CPU) with split_module_by: [:locale]. Looking such a translation up takes
about 45 ns instead of 15 ns; everything else is unchanged, and every
message of the catalog, with complete, partial and extra bindings, returns
identical results from both versions.

Pull Request Pull Request #446: Store translations without interpolation in a literal map instead of function clauses

Coverage Stats

15 of 15 new or added lines in 1 file covered. (100.0%)

2 existing lines in 1 file now uncovered.

768 of 819 relevant lines covered (93.77%)

37.17 hits per line