stacklok / toolhive / 38753219600
71%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 954
Run time 3min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 71.304% (+0.002%) from 71.302%
38753219600

push

github

web-flow 
Codify conventions stated in recent code reviews (#6812)

* Check documented contracts before relying on them

Doc and interface comments in this codebase are read as the contract, and new code has leaned on promises those comments made that no implementation kept.
Add a bullet to the comment-synchronization rule: before depending on a documented behavior, confirm that every implementation honors it, and either make them honor it or rewrite the comment to what the implementations share.

Signed-off-by: Aleksandr Filippov <71711753+alex-feel@users.noreply.github.com>

* Calibrate log levels to who triggers the line

The logging rule lists levels but says nothing about volume or placement, so WARN lines have been proposed per request for conditions fixed at startup, before the logged value was final, and once in the log and again in the returned error.
Add bullets for logging startup conditions once, keeping caller-triggered lines at DEBUG or bounded unless they are the deliberate rejection signal, logging the final value under the existing key and the server-minted id, logging a failure once, and naming the cause of a rejection.
Mirror the volume principle in docs/logging.md so the developer guide and the rule agree.

Signed-off-by: Aleksandr Filippov <71711753+alex-feel@users.noreply.github.com>

* Document observable changes in docs and PR body

CLAUDE.md asks for docs/arch updates on architecture changes, but a change a client or operator can observe need not touch any architecture, and one has reached review with nothing in docs/ describing it.
Require such changes to update the subsystem's docs/ page in the same PR and to fill the PR body's user-facing section as before and after.
Ask that a deliberate deviation from a sibling code path, or an accepted trade-off, be stated in the PR body or in a comment at the site.
Mirror the requirement in the PR creation rule, where the user-facing section is described.

Signed-off-by: Aleksandr Filippov <71711... (continued)

86917 of 121897 relevant lines covered (71.3%)

126.8 hits per line

Coverage Regressions

Lines Coverage ∆ File
81
78.27
-2.22% pkg/authserver/server_impl.go
44
91.85
0.22% pkg/authserver/config.go
3
61.43
-4.29% pkg/state/runconfig.go
2
68.8
-0.85% pkg/ignore/processor.go
2
73.66
-0.27% pkg/transport/proxy/streamable/streamable_proxy.go
2
59.0
-0.21% pkg/workloads/manager.go
1
92.31
-7.69% pkg/authserver/server.go
Jobs
ID Job ID Ran Files Coverage
1 38753219600.1 954
71.3
GitHub Action Run
Source Files on build 38753219600