supabase / supabase-flutter / 38746912467

92%

push

github

fix(postgrest): address a hinted embed by its table name outside the select list (#1962)

## Summary

Follow-up to #1960, from a review of that PR.

A relation with a foreign key hint and no alias, such as a hand-written
`PostgrestToOneRelation('users!messages_username_fkey', ...)`, was
addressed by its hinted name everywhere outside the `select` list.
PostgREST matches those paths against the alias or the table name only.
Checked against the local stack:

| Request | Result |
|---|---|
| `messages.limit=1` | applied, 1 row |
| `messages!username.limit=1` | silently ignored, every row |
| `order=users(username).desc` | applied |
| `order=users!username(username).desc` | PGRST100 parse error |

Outside the `select` list, the embed is now addressed by its alias, or
by the table name without the hint. This fixes `embedded()` scopes, and
also the to-one `order` keys and `embeddedFilterName`, which had the
same bug before #1960. Typegen always pairs a hint with an alias, so
generated tables were not affected.

## Other changes

- The `embedded()` dartdoc now says exactly what a repeated call does: a
later limit replaces only the limit, and a later range replaces both the
offset and the limit.
- The untyped `order()` merges its key through `appendOrderKey` instead
of duplicating the merge logic.
- In `MIGRATION.md`, the foreign key paragraph is back next to the
relation text it explains, and the snippet is wrapped to 80 characters.

## Testing

- New unit tests cover a hinted embed with no alias in a scope, in an
order key and in a filter name.
- The full postgrest suite passes against the local stack (623 tests).
`melos analyze` and `dcm analyze` are clean.


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

* **Bug Fixes**
* Embedded ordering and filters now correctly use the referenced table
name when a foreign-key hint is present without an alias, while
preserving the hint in the select expression.

* ... (continued)

3 of 3 new or added lines in 2 files covered. (100.0%)

10062 of 10906 relevant lines covered (92.26%)

5.36 hits per line