kubeflow / trainer / 38743319496
75%

DEFAULT BRANCH: master
Ran
Jobs 1
Files 46
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 74.223% (+1.0%) from 73.227%
38743319496

push

github

web-flow 
chore(runtimes): add ValidateObjects test coverage for TrainingRuntime and ClusterTrainingRuntime (#3892)

* test(runtime): add test coverage for ValidateObjects methods

Add comprehensive test coverage for TrainingRuntime.ValidateObjects()
and ClusterTrainingRuntime.ValidateObjects() methods which previously
had zero test coverage.

Tests cover existing behavior only:
- Runtime exists and is valid (success path)
- Runtime does not exist (returns field error)
- Runtime in different namespace (returns field error for TrainingRuntime)
- Deprecated runtime (returns warning for ClusterTrainingRuntime)

All tests verify the current implementation without proposing new
validation rules.

Signed-off-by: Prateek Rai <prateekrai903@gmail.com>

* chore(test): address PR review comments for ValidateObjects tests

- Move ValidateObjects tests to per-type test files (trainingruntime_test.go and clustertrainingruntime_test.go) instead of standalone validateobjects_test.go
- Use cmp.Diff pattern for assertions instead of manual field error counting
- Remove duplicate test case for runtime in different namespace
- Simplify warnings handling by using []string type conversion

This addresses review comments from @robert-bell to improve test organization and consistency with existing test patterns in the codebase.

Signed-off-by: Prateek Rai <prateekrai903@gmail.com>

* Update pkg/runtime/core/trainingruntime_test.go

Co-authored-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
Signed-off-by: Prateek Rai <prateekrai903@gmail.com>

* Update pkg/runtime/core/trainingruntime_test.go

Co-authored-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
Signed-off-by: Prateek Rai <prateekrai903@gmail.com>

* Update pkg/runtime/core/trainingruntime_test.go

Co-authored-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
Signed-off-by: Prateek Rai <prateekrai903@gmail.com>

* Update pkg/runtime/core/trainingruntime_test.go

Co-authored-by: Andrey Velichkevich <andrey... (continued)

3202 of 4314 relevant lines covered (74.22%)

0.75 hits per line

Jobs
ID Job ID Ran Files Coverage
1 38743319496.1 46
74.22
GitHub Action Run
Source Files on build 38743319496