KusionStack / kusion / 38733887864

46%

main: 46%

Pull #1466

github

style: fix findings reported by golangci-lint v2

The linters bundled with golangci-lint v2 report findings that v1 did
not. All are small and do not change behaviour, except the slog calls,
which logged the error as the message and produced a !BADKEY attribute.

- govet slog: logger.Error(err.Error(), "msg", "error", err) becomes
  logger.Error("msg", "error", err).
- staticcheck SA1006: fmt.Errorf(s) becomes errors.New(s), and
  fmt.Printf(s) becomes fmt.Print(s).
- staticcheck S1009: drop nil checks that len() already covers.
- predeclared: rename local "max" variables, which shadow the Go 1.21
  builtin, to "maxItems".
- prealloc: preallocate slices in non-test code.
- gofumpt: reformat k8s_printer.go.

Co-authored-by: Iamrushabhshahh <rushabhshah842@gmail.com>
Signed-off-by: Iamrushabhshahh <rushabhshah842@gmail.com>

19 of 55 new or added lines in 16 files covered. (34.55%)

11383 of 24558 relevant lines covered (46.35%)

0.51 hits per line