accordproject / concerto / 38722486871

98%

push

github

fix(concerto-core): make DateTime parsing strict by default and reject impossible dates (#1576)

* fix(concerto-core): reject impossible dates in strict DateTime parsing

Strict mode with strictQualifiedDateTimes previously allowed impossible
calendar dates (e.g. Feb 30, non-leap Feb 29) and T24:00:00 to silently
roll over to the next valid instant instead of throwing ValidationException.

- Add isValidDateTime helper to validate calendar date parts and time ranges
- Reject impossible dates and T24:00 in JSONPopulator when strictQualifiedDateTimes is true
- Add strict mode option to DateTimeUtil.setCurrentTime to reject impossible/non-ISO dates
- Add unit tests for strict DateTime validation

Closes #1561

Signed-off-by: Tushar Singh <tusharsingh222555@gmail.com>

* fix(concerto-core): default to strict DateTime parsing in fromJSON and setCurrentTime

Signed-off-by: Tushar Singh <tusharsingh222555@gmail.com>

---------

Signed-off-by: Tushar Singh <tusharsingh222555@gmail.com>

2354 of 2467 branches covered (95.42%)

Branch coverage included in aggregate %.

40 of 40 new or added lines in 3 files covered. (100.0%)

4245 of 4288 relevant lines covered (99.0%)

124809.55 hits per line