elixir-gettext / gettext / a851c5b2dabeaeb4481107be59c0bae74675038a-PR-437

94%

main: 94%

Pull #437

github

Support umbrella and deprecated backends in mix gettext.generate

Two cases where the task silently dropped messages, found while reviewing
the previous fix:

  * In an umbrella project, each application scanned only its own BEAM
    files. mix gettext.extract compiles the whole umbrella before any
    application pops its backends from the extractor agent, so a backend
    defined in one application receives the messages of all the others.
    The task is no longer recursive: at the umbrella root it compiles the
    umbrella, loads the messages of every application (with the
    configuration the umbrella passes down to them, like Mix does) and
    only then generates each application's POT files.

  * Backends defined with the deprecated "use Gettext, otp_app: ..." only
    extracted their messages under mix gettext.extract: their generated
    macros called Gettext.Extractor.extract/6 directly, so with
    automatic_extraction enabled the backend marker was persisted but no
    messages were, and existing POT entries were pruned. All macros now go
    through Gettext.Extractor.extract_and_persist/6.

Also reenable every configured compiler (not only the Elixir one) before
compiling, name the right task in the --check-up-to-date error, validate
the domain and msgctxt of persisted entries, and document that the toggle
is compile-time configuration that does not belong in config/runtime.exs.

72 of 75 new or added lines in 4 files covered. (96.0%)

745 of 796 relevant lines covered (93.59%)

36.37 hits per line