supabase / supabase-flutter / 38712825303

92%

Build Type

push

github

Committed by web-flow

Commit Message

fix(auth)!: decode omitted OAuthClient fields and drop the unused scope (#1957)

Aligns `OAuthClient` and the OAuth client options with what Auth
actually returns and accepts.

- `OAuthClient.tokenEndpointAuthenticationMethod` and
`OAuthClient.registrationType` are nullable. Auth marks
`token_endpoint_auth_method` and `registration_type` as `omitempty` in
`OAuthServerClientResponse`, but they were decoded as required, so a
response without them would throw.
- `OAuthClient.scope` is removed. `OAuthServerClientResponse` has no
`scope` field, so it was always `null`.
- `CreateOAuthClientOptions.scope` and `UpdateOAuthClientOptions.scope`
are removed. Neither `OAuthServerClientRegisterParams` nor
`OAuthServerClientUpdateParams` reads a `scope` key, so Auth ignored it.
Scopes are requested per authorization through the `scope` query
parameter on `/oauth/authorize`.

The OAuth integration tests passed `scope: 'email'` when creating
clients and asserted that the authorization details echoed it back. That
only held because the server's default scope is `email`. The test
fixture now sends `scope=email` on the authorize request instead.

`MIGRATION.md` has a section for each break.

Linear: SDK-2160


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

* **Documentation**
* Clarified that OAuth client authentication method and registration
type may be absent.
* Documented that scopes are set on authorization requests and returned
with authorization details.
* **Bug Fixes**
* OAuth client details now handle missing authentication method and
registration type values.
* **API Changes**
* Removed `scope` from OAuth client models and client creation and
update options.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

Coverage Stats

3 of 3 new or added lines in 1 file covered. (100.0%)

27 existing lines in 6 files now uncovered.

9523 of 10390 relevant lines covered (91.66%)

5.27 hits per line