supabase / storage / 38705957272

86%

push

github

fix: release database leases after tus and orphan streams finish (#1510)

## What kind of change does this PR introduce?

Bug fix

## What is the current behavior?

A client close after the final TUS patch released the db lease while
upload finalization was still running. The abort hook also released
connections whose request bodies had already arrived.

Admin orphan get/delete streams bypass `onSend`. Completed streams and
disconnected deletes held their db leases until the 60 minute timeout.

## What is the new behavior?

TUS releases the db lease in `writeHead` after finish stores the object.
The abort hook releases leases only for incomplete request bodies.

Orphan get/delete handlers release their leases in finally after scanner
and stream cleanup (success, failure or disconnect).

Signed-off-by: Ferhat Elmas <elmas.ferhat@gmail.com>

7693 of 9478 branches covered (81.17%)

Branch coverage included in aggregate %.

5 of 5 new or added lines in 3 files covered. (100.0%)

13354 of 15080 relevant lines covered (88.55%)

859.85 hits per line