containernetworking / plugins / 38695257258

53%

master: 55%

Pull #1289

github

host-local: implement CNI v1.1 GC

Adds the GC verb to host-local, replacing the FIXME placeholder in main.
The runtime hands GC the complete set of attachments it still considers
live, and every reservation outside that set is released. That is how an
allocation leaked by a DEL which never arrived gets reclaimed, which is
the case the issue calls out.

Three details the implementation has to get right, each covered by a test:

The lock and the per-range last_reserved_ip markers live in the same
directory as the reservations, so a GC that simply walked the data dir
would delete them.

Reservations written by older versions hold only a container ID with no
ifname. ReleaseByID already falls back to matching those, and GC has to
agree, otherwise the first GC after an upgrade would release every
pre-upgrade allocation.

An empty valid-attachments list means every reservation for this network
is stale. It is not the same as having nothing to do.

GC deliberately does not rewind last_reserved_ip, so a reclaimed address
returns to service on wrap-around rather than being handed out next. That
keeps allocation order unchanged for everyone else.

Status is left as a separate change.

Signed-off-by: Ravi Arnan <raviarnankeren@gmail.com>

44 of 54 new or added lines in 3 files covered. (81.48%)

5242 of 9799 relevant lines covered (53.5%)

29.02 hits per line