map-services / gps-routes-api / 38693762007

54%

Build Type

push

github

Committed by web-flow

Commit Message

feat: SQLite repository implementation (Phase 4 of #120), ported to current main (#181)

## Summary
Ports the Phase‑4 SQLite repository work (issue #120) from the obsolete
`phase-4-repository-and-core-logic-2` branch onto current `main`,
resolving all
compile/test breakages and enabling a working SQLite+FTS5+Spatialite
driver. The
Phase‑4 code is gated behind the `sqlite` build tag.

## Branch history (8 commits ahead of main)
Original Phase‑4 commits, rebased onto `main` (merge‑base `465bdbd2c`):
- `791ae9abe` feat: add SQLite support
- `4f670ed53` refactor: standardize coordinate naming in SQLite
- `d413b8ce5` refactor: remove debug logging in sqlite

Ports/fixups:
- `1ff940f14` fix(sqlite): make Phase‑4 code compile and pass on current
main
- `f7bf54928` fix: resolve Phase‑4 rebase regressions in db package so
CI passes
- `19b5336d0` fix(sqlite): handle ignored returns + fix SQLiteDialect
ST_DWithin typo
- `fab773af1` feat(sqlite): enable Spatialite via driver config +
graceful fallback
- `05cbcaeb8` fix(sqlite): gofmt-clean + errcheck in sqlite path
- `428e155ba` ci: exercise the SQLite build path in CI (tags:
sqlite,sqlite_fts5)
- `f72a311cb` fix(sqlite): BuildMbr for Spatialite 5.x bbox + CI loads
mod_spatialite ← NEW

## Fixes applied
1. **Module import paths** — files still imported
`github.com/rm-hull/gps-routes-api/...`;
updated to `github.com/map-services/gps-routes-api/...` (15 refs across
6 files).
   Without this the `sqlite`-tagged packages fail to compile.
2. **SQLite test schema mismatch** — `setupSQLiteTestDB` built `routes`
with
`_geoloc_lat/_geoloc_lon`; repo code +
`db/migrations/00002_sqlite_schema.sql`
use `latitude/longitude` → "no column named longitude". Aligned to the
schema.
3. **FTS5 availability probe** — `SELECT fts5(?)` is invalid (FTS5 is a
module, not
   a scalar function) and always reported FTS5 absent. Replaced with
   `CREATE VIRTUAL TABLE _fts5_probe USING fts5(...)`.
4. **LIMIT/OFFSET ordering regression** — car... (continued)

Coverage Stats

53 of 70 new or added lines in 5 files covered. (75.71%)

2 existing lines in 1 file now uncovered.

608 of 1736 relevant lines covered (35.02%)

0.35 hits per line