solidjs / solid / 38689412090

78%

main: 89%

push

github

fix(frames): morph drops a stale text node instead of relocating what follows (#4084)

* fix(frames): morph drops a stale text node instead of relocating what follows

An empty text hole renders `<!--$--><!--/-->` with no text node. When a
hole went from text to empty, reconcileChildren met the old text node
against the new closing comment, inserted the comment, then relocated
the next element (found by lookahead) in front of the stale text. Every
emptied cell re-inserted its following subtree.

A text node holds no client state, so when the new side has no text at
that position the reconcile now drops it and lines up again.

server-dbmon, 400 rows, 10% changing, 4x CPU: 28 popover subtrees
re-inserted per tick -> 0; main-thread busy 771-910 -> 571-705 ms/s.
Size: +71 B minified on the frames client and the server-component pages.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LZkrATgvFJjgFRdDB4Drcq

* chore(size): note the maintainer's acceptance of the base page floor raise

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LZkrATgvFJjgFRdDB4Drcq

* chore(size): ratchet up caps to what next measures after #4067

createDeferred (#4067) grew the signals core: + until/refresh goes over
its cap (8.07 -> 8.11 KB, 22,195 -> 22,255 B minified), and the four SC
page scenarios sit within 1-6 B of the minified allowance. Re-record them
at the merged tree's measurement: frozen page floors 106,772 -> 106,786
and 118,990 -> 119,009, router pages 130,653 -> 130,667 and
144,190 -> 144,205. Brotli caps on the pages are unchanged.

Accepted by the maintainer (2026-10-15, "Ratchet up").

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LZkrATgvFJjgFRdDB4Drcq

---------

Co-authored-by: Claude <noreply@anthropic.com>

755 of 1046 branches covered (72.18%)

Branch coverage included in aggregate %.

1086 of 1328 relevant lines covered (81.78%)

27.82 hits per line