source-academy / frontend / 38656361214

48%

push

github

CSE machine: arrows from frames turn further out; hover on their in-frame part (#4476)

* CSE machine: arrows from frames turn further from the frame, and hover on their in-frame part

Binding arrows ran only ArrowPostFrameStraightLength (10) past the frame before
turning, less than the corner radius (20), so the curve began inside the frame
and the vertical part ended up beside the arrowheads into the frame. They now use
a separate ArrowFromFrameStraightLength (30); the stash, control and Java arrows
are unchanged.

The copy of an arrow's in-frame part drawn above the frame had the default hit
area, about the stroke's width, so the frame got the hover. It now hits as wide
as the arrow underneath.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

* CSE machine: the vertical part of an arrow from a frame is midway between the frame and the objects

ArrowFromFrameStraightLength is half of FrameMarginX (25), not 30.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

* CSE machine: draw a binding's arrow before its key

The in-frame part of the arrow has a wide hit area and starts at the key's right
edge, so drawn after the key it could take the hover from the last pixels of the
key (review of #4476).

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com>

3403 of 8116 branches covered (41.93%)

Branch coverage included in aggregate %.

7505 of 15042 relevant lines covered (49.89%)

41.53 hits per line